Restore current SBML test-suite compatibility - #223
Conversation
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
70b2e35 to
18eb314
Compare
|
Rebased onto current Local verification on Julia 1.12.6:
|
|
Exact downstream validation against the failing ModelingToolkit workflow is now complete. Environment:
I ran the same downstream workflow shape from the ModelingToolkit root: using Pkg
Pkg.Registry.add()
Pkg.develop(PackageSpec(path = "./lib/ModelingToolkitBase"))
Pkg.develop(PackageSpec(path = "."))
Pkg.update()
Pkg.test(; coverage = true)The unmodified SBMLToolkit With this PR stacked, resolution selected
A first-parent compatibility bisect identifies Additional checks on this exact head: Runic |
Ignore this PR until it has been reviewed by @ChrisRackauckas.
Summary
SBMLToolkitTestSuite0.0.5 stack and the current 1.x stackderivative_discontinuity!support is required by current event testsmtkcompilecannot eliminate callback targetsODESystemImporterthrough the existing Catalyst 15/16 conversion helperRoot cause
The exact
SBMLToolkitTestSuite = "0.0.5"test compat forced the downstream test job onto ModelingToolkit 9, OrdinaryDiffEq 6, and Sundials 4. It therefore could not resolve with SBMLToolkit's declared ModelingToolkit 10/11 and OrdinaryDiffEq 7 support.Widening that compat exposed three current-stack issues:
ODESystemImporterstill called the Catalyst conversion API removed in Catalyst 16 / ModelingToolkit 11.Validation
Run locally with Julia 1.12.6:
529c98930ee14191a0e90a32e37698ff6dc40309, OrdinaryDiffEq 7.2.0, SBMLToolkitTestSuite 1.1.2, Sundials 6.4.2GROUP=Core Pkg.test("SBMLToolkit"; coverage=true)passedGROUP=Core Pkg.test("SBMLToolkit"; coverage=true)passedRunic --check .passedLocal
GROUP=QAreached 19/20 checks. Its sole failure was SciMLTesting's new "No unapproved public reexports" check for seven longstanding exports; the identical failure was reproduced on an unmodifiedmaincheckout atbb863863eac445a03ef97bb4690550711826f14a.Hosted CI reached a terminal 10/10 pass: Core passed on Julia LTS, current, and pre-release; QA, documentation, downgrade, Runic, Runic suggestions, spellcheck, and test discovery all passed.